From 99c3d48f1021e59d8db0873ae9b626594954e44f Mon Sep 17 00:00:00 2001 From: Jannis Harder Date: Tue, 14 Jun 2011 17:48:26 +0200 Subject: Several speed optimizations git-svn-id: svn://sunsvr01.isp.uni-luebeck.de/swproj13/trunk@438 72836036-5685-4462-b002-a69064685172 --- .../fdsolver/constraint/ComparatorConstraint.java | 39 +++++++++++++--------- 1 file changed, 23 insertions(+), 16 deletions(-) (limited to 'src/jrummikub/ai/fdsolver/constraint/ComparatorConstraint.java') diff --git a/src/jrummikub/ai/fdsolver/constraint/ComparatorConstraint.java b/src/jrummikub/ai/fdsolver/constraint/ComparatorConstraint.java index ab0edde..019de92 100644 --- a/src/jrummikub/ai/fdsolver/constraint/ComparatorConstraint.java +++ b/src/jrummikub/ai/fdsolver/constraint/ComparatorConstraint.java @@ -6,6 +6,7 @@ import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.Comparator; +import java.util.NoSuchElementException; import jrummikub.ai.fdsolver.Constraint; import jrummikub.ai.fdsolver.Propagator; @@ -17,8 +18,9 @@ public class ComparatorConstraint extends Constraint { Comparator comparator, reverseComparator; ComparatorPropagator trueX, trueY, falseX, falseY; boolean allowEqual; - - ComparatorConstraint(final Comparator comparator, boolean allowEqual, Var x, Var y) { + + ComparatorConstraint(final Comparator comparator, boolean allowEqual, + Var x, Var y) { this.x = x; this.y = y; this.comparator = comparator; @@ -31,37 +33,42 @@ public class ComparatorConstraint extends Constraint { }; trueX = new ComparatorPropagator(comparator, allowEqual, x, y); trueY = new ComparatorPropagator(reverseComparator, allowEqual, y, x); - falseX = new ComparatorPropagator(reverseComparator, !allowEqual, x, y); + falseX = new ComparatorPropagator(reverseComparator, !allowEqual, x, + y); falseY = new ComparatorPropagator(comparator, !allowEqual, y, x); } - + @Override public Collection> getWatchedVars() { - return Arrays.>asList(x,y); + return Arrays.> asList(x, y); } @Override public Collection getPropagators(boolean negate) { if (negate) { - return Arrays.asList(falseX,falseY); + return Arrays. asList(falseX, falseY); } else { - return Arrays.asList(trueX,trueY); + return Arrays. asList(trueX, trueY); } } @Override public Satisfiability getSatisfiability() { - T maxX = Collections.max(x.getRange(), comparator); - T minY = Collections.min(y.getRange(), comparator); - if (comparator.compare(maxX, minY) < (allowEqual ? 1 : 0)) { - return TAUT; - } - T minX = Collections.min(x.getRange(), comparator); - T maxY = Collections.max(y.getRange(), comparator); - if (comparator.compare(maxY, minX) < (allowEqual ? 0 : 1)) { + try { + T maxX = Collections.max(x.getRange(), comparator); + T minY = Collections.min(y.getRange(), comparator); + if (comparator.compare(maxX, minY) < (allowEqual ? 1 : 0)) { + return TAUT; + } + T minX = Collections.min(x.getRange(), comparator); + T maxY = Collections.max(y.getRange(), comparator); + if (comparator.compare(maxY, minX) < (allowEqual ? 0 : 1)) { + return UNSAT; + } + return SAT; + } catch (NoSuchElementException e) { return UNSAT; } - return SAT; } } -- cgit v1.2.3