From a6c9f0648db56175ee9e077e2ca631b678552835 Mon Sep 17 00:00:00 2001 From: Ondrej Filip Date: Thu, 28 May 2009 13:37:04 +0200 Subject: Missing boolean comparison added. --- filter/filter.c | 3 ++- filter/test.conf | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) (limited to 'filter') diff --git a/filter/filter.c b/filter/filter.c index 313d2fa..944befb 100644 --- a/filter/filter.c +++ b/filter/filter.c @@ -120,7 +120,8 @@ val_compare(struct f_val v1, struct f_val v2) } switch (v1.type) { case T_ENUM: - case T_INT: + case T_INT: + case T_BOOL: case T_PAIR: if (v1.val.i == v2.val.i) return 0; if (v1.val.i < v2.val.i) return -1; diff --git a/filter/test.conf b/filter/test.conf index af88907..f1cdf04 100644 --- a/filter/test.conf +++ b/filter/test.conf @@ -155,6 +155,9 @@ string s; b = true; print "Testing bool: ", b, ", ", !b; + + if ( b = true ) then print "Testing bool comparison b = true: ", b; + else { print "*** FAIL: TRUE test failed" ; quitbird; } pxs = [ 1.2.0.0/16, 1.4.0.0/16+]; print "Testing prefix sets: "; @@ -202,4 +205,4 @@ int j; accept "ok I take that"; } -eval __startup(); \ No newline at end of file +eval __startup(); -- cgit v1.2.3 From d59405ec6652e95f4825492c7322536bb7044db0 Mon Sep 17 00:00:00 2001 From: Ondrej Filip Date: Fri, 29 May 2009 23:02:36 +0200 Subject: Typo in warning fixed. --- filter/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'filter') diff --git a/filter/filter.c b/filter/filter.c index 944befb..fe3c9cb 100644 --- a/filter/filter.c +++ b/filter/filter.c @@ -141,7 +141,7 @@ val_compare(struct f_val v1, struct f_val v2) case T_STRING: return strcmp(v1.val.s, v2.val.s); default: - debug( "Compare of unkown entities: %x\n", v1.type ); + debug( "Compare of unknown entities: %x\n", v1.type ); return CMP_ERROR; } } -- cgit v1.2.3 From 43de796b8a10f561d8b3ef64a86e5ce70de01eb5 Mon Sep 17 00:00:00 2001 From: Ondrej Filip Date: Fri, 29 May 2009 23:04:54 +0200 Subject: Function pm_path_compare() checked just length of the bgpmasks --- filter/filter.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'filter') diff --git a/filter/filter.c b/filter/filter.c index fe3c9cb..deaea34 100644 --- a/filter/filter.c +++ b/filter/filter.c @@ -64,6 +64,8 @@ pm_path_compare(struct f_path_mask *m1, struct f_path_mask *m2) while (1) { if ((!m1) || (!m2)) return !((!m1) && (!m2)); + + if ((m1->kind != m2->kind) || (m1->val != m2->val)) return 1; m1 = m1->next; m2 = m2->next; } -- cgit v1.2.3 From 9be1086d2970633fb5af2a1faaae16d5a1cf48ea Mon Sep 17 00:00:00 2001 From: Ondrej Filip Date: Fri, 29 May 2009 23:08:28 +0200 Subject: New type variable 'V' defined in filters. This type is checked only for name, never for value in function filter_same() --- filter/config.Y | 3 ++- filter/filter.c | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) (limited to 'filter') diff --git a/filter/config.Y b/filter/config.Y index 6d9b064..fe79496 100644 --- a/filter/config.Y +++ b/filter/config.Y @@ -397,8 +397,9 @@ term: case SYM_VARIABLE | T_PATH: case SYM_VARIABLE | T_PATH_MASK: case SYM_VARIABLE | T_CLIST: - $$->code = 'C'; + $$->code = 'V'; $$->a1.p = $1->def; + $$->a2.p = $1->name; break; default: cf_error("%s: variable expected.", $1->name ); diff --git a/filter/filter.c b/filter/filter.c index deaea34..fe3a2ac 100644 --- a/filter/filter.c +++ b/filter/filter.c @@ -489,6 +489,7 @@ interpret(struct f_inst *what) else res.val.i = what->a2.i; break; + case 'V': case 'C': res = * ((struct f_val *) what->a1.p); break; @@ -855,10 +856,12 @@ i_same(struct f_inst *f1, struct f_inst *f2) case T_PREFIX_SET: if (!trie_same(f1->a2.p, f2->a2.p)) return 0; + break; case T_SET: if (!same_tree(f1->a2.p, f2->a2.p)) return 0; + break; case T_STRING: if (strcmp(f1->a2.p, f2->a2.p)) @@ -873,6 +876,10 @@ i_same(struct f_inst *f1, struct f_inst *f2) if (val_compare(* (struct f_val *) f1->a1.p, * (struct f_val *) f2->a1.p)) return 0; break; + case 'V': + if (strcmp((char *) f1->a2.p, (char *) f2->a2.p)) + return 0; + break; case 'p': case 'L': ONEARG; break; case '?': TWOARGS; break; case '0': case 'E': break; -- cgit v1.2.3