From 0077aab4f9041e4d05d2d6916edfb0e15738cb37 Mon Sep 17 00:00:00 2001 From: Martin Mares Date: Mon, 31 May 2004 18:16:42 +0000 Subject: The code was broken for external /29 to /32 routes. Assuming that you have one machine publishing a route to 10.1.1.3/32 and another one publishing a route to 10.1.1.4/32. If the first machine went down the route to 10.1.1.4/32 was wrongly killed by the old code, leading either to missing routes or worse to bug()s like "Router parent does not have next hop" or just segfaults. The patch fixes this but in the long term a redesign is required here. Note that the patch doesn't worse the situation, instead it prevents the problems stated. The redesign is required to handle multiple routes to small subnets properly. (by Andreas) Feela, I think that this is at least a good temporary fix, but it's of course up to you to decide. --- proto/ospf/topology.h | 1 + 1 file changed, 1 insertion(+) (limited to 'proto/ospf/topology.h') diff --git a/proto/ospf/topology.h b/proto/ospf/topology.h index c4bbc9e..d85173f 100644 --- a/proto/ospf/topology.h +++ b/proto/ospf/topology.h @@ -54,6 +54,7 @@ void addifa_rtlsa(struct ospf_iface *ifa); void originate_rt_lsa(struct ospf_area *oa); void originate_net_lsa(struct ospf_iface *ifa); int can_flush_lsa(struct ospf_area *oa); +int max_ext_lsa(unsigned pxlen); void originate_ext_lsa(net *n, rte *e, struct proto_ospf *po, struct ea_list *attrs); #endif /* _BIRD_OSPF_TOPOLOGY_H_ */ -- cgit v1.2.3