From d9dc87d8409ddf8361b7fcb311ae97088ed1d984 Mon Sep 17 00:00:00 2001 From: Matthias Schiffer Date: Tue, 20 Aug 2013 06:02:29 +0200 Subject: Fix lots of -Wextra warnings Everything clang and GCC warn about, except GCC's missing-field-initializers which are just stupid as they don't allow {} syntax to zero a field. --- src/receive.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/receive.c') diff --git a/src/receive.c b/src/receive.c index bf4b93e..d91a5cd 100644 --- a/src/receive.c +++ b/src/receive.c @@ -30,7 +30,7 @@ #include "peer.h" -static inline void handle_socket_control(fastd_context_t *ctx, struct msghdr *message, const fastd_socket_t *sock, fastd_peer_address_t *local_addr) { +static inline void handle_socket_control(struct msghdr *message, const fastd_socket_t *sock, fastd_peer_address_t *local_addr) { memset(local_addr, 0, sizeof(fastd_peer_address_t)); const char *end = (char*)message->msg_control + message->msg_controllen; @@ -96,7 +96,7 @@ static inline void handle_socket_receive_known(fastd_context_t *ctx, fastd_socke } } -static inline bool is_unknown_peer_valid(fastd_context_t *ctx, const fastd_peer_address_t *remote_addr) { +static inline bool allow_unknown_peers(fastd_context_t *ctx) { return ctx->conf->has_floating || ctx->conf->on_verify; } @@ -136,7 +136,7 @@ static inline void handle_socket_receive(fastd_context_t *ctx, fastd_socket_t *s if (peer) { handle_socket_receive_known(ctx, sock, local_addr, remote_addr, peer, buffer); } - else if(is_unknown_peer_valid(ctx, remote_addr)) { + else if (allow_unknown_peers(ctx)) { handle_socket_receive_unknown(ctx, sock, local_addr, remote_addr, buffer); } else { @@ -173,7 +173,7 @@ void fastd_receive(fastd_context_t *ctx, fastd_socket_t *sock) { buffer.len = len; - handle_socket_control(ctx, &message, sock, &local_addr); + handle_socket_control(&message, sock, &local_addr); #ifdef USE_PKTINFO if (!local_addr.sa.sa_family) { -- cgit v1.2.3