diff options
author | Ondrej Zajicek <santiago@crfreenet.org> | 2009-09-04 11:24:08 +0200 |
---|---|---|
committer | Ondrej Zajicek <santiago@crfreenet.org> | 2009-09-04 11:24:08 +0200 |
commit | daeeb8e982a3463f4a866e805b64f214d9f44160 (patch) | |
tree | 64888a5b01ab18f6ffca311af766c242f8c3b1bc /lib | |
parent | 05198c12f48c9d4a65ee6d1d4117bd8067a71131 (diff) | |
download | bird-daeeb8e982a3463f4a866e805b64f214d9f44160.tar bird-daeeb8e982a3463f4a866e805b64f214d9f44160.zip |
Clear memory allocated by ralloc().
This also fixes bug that timer->recurrent was not cleared
in tm_new() and unexpected recurrence of startup timer
in BGP confused state machine and caused crash.
Diffstat (limited to 'lib')
-rw-r--r-- | lib/event.c | 4 | ||||
-rw-r--r-- | lib/mempool.c | 4 | ||||
-rw-r--r-- | lib/resource.c | 5 |
3 files changed, 3 insertions, 10 deletions
diff --git a/lib/event.c b/lib/event.c index 55a9c48..d556cd0 100644 --- a/lib/event.c +++ b/lib/event.c @@ -63,10 +63,6 @@ event * ev_new(pool *p) { event *e = ralloc(p, &ev_class); - - e->hook = NULL; - e->data = NULL; - e->n.next = NULL; return e; } diff --git a/lib/mempool.c b/lib/mempool.c index e6f277b..03a6e6b 100644 --- a/lib/mempool.c +++ b/lib/mempool.c @@ -64,13 +64,9 @@ linpool *lp_new(pool *p, unsigned blk) { linpool *m = ralloc(p, &lp_class); - m->ptr = m->end = NULL; - m->first = m->current = NULL; m->plast = &m->first; - m->first_large = NULL; m->chunk_size = blk; m->threshold = 3*blk/4; - m->total = m->total_large = 0; return m; } diff --git a/lib/resource.c b/lib/resource.c index 8f91450..a4d8751 100644 --- a/lib/resource.c +++ b/lib/resource.c @@ -183,13 +183,14 @@ rdump(void *res) * * This function is called by the resource classes to create a new * resource of the specified class and link it to the given pool. - * Size of the resource structure is taken from the @size field - * of the &resclass. + * Allocated memory is zeroed. Size of the resource structure is taken + * from the @size field of the &resclass. */ void * ralloc(pool *p, struct resclass *c) { resource *r = xmalloc(c->size); + bzero(r, c->size); r->class = c; add_tail(&p->inside, &r->n); |