Age | Commit message (Collapse) | Author |
|
There is no reak callback scheduler and previous behavior causes
bad things during hard congestion (like BGP hold timeouts).
Smart callback scheduler is still missing, but main loop was
changed such that it first processes all tx callbacks (which
are fast enough) (but max 4* per socket) + rx callbacks for CLI,
and in the second phase it processes one rx callback per
socket up to four sockets (as rx callback can be slow when
there are too many protocols, because route redistribution
is done synchronously inside rx callback). If there is event
callback ready, second phase is skipped in 90% of iterations
(to speed up CLI during congestion).
|
|
|
|
|
|
|
|
|
|
This also fixes bug that timer->recurrent was not cleared
in tm_new() and unexpected recurrence of startup timer
in BGP confused state machine and caused crash.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
BGP on BSD was bound to random port. I am surprised that
nobody noticed it already.
|
|
|
|
|
|
|
|
If other side of a socket is sending data faster than
BIRD is processing, BIRD does not schedule any other
callbacks (events, timers, rx/tx callbacks).
|
|
|
|
|
|
|
|
|
|
routes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Independent sessions on netlink sockets mixed state
in some common variables.
|
|
FreeBSD coded added. BSD cannot set BGP passwords itself.
This has to be done by external command.
|
|
|
|
|
|
Under specific circumstances there might be two mixed-up
netlink sessions (one for scan, the other for route change
request). This patch separates netlink scans and requests
to two fds (and seq counters).
This should fix http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=428865
|
|
Missing macro leads to not calling some of protocol's
callbacks.
|
|
KRF_INSTALLED flag was not cleared during reconfiguration
that lead to not removing routes during reconfigure when
export rules changed.
We also should not try to remove routes we didi not installed,
on Linux this leads to warnings (as kernel checks route source
field and do not allow to remove non-bird routes) but we should
not rely on it.
|
|
|
|
Older kernel headers (the ones in Debian Sarge) does not
have __kernel_sockaddr_storage .
|
|
executing sk_read().
|
|
|
|
|
|
|
|
|
|
|
|
ttl 1.
|
|
|
|
|
|
'Invalid broadcast address' error is reported only once for
an interface and not during every interface scan.
|
|
Bird sometimes reported 'bird: nl_parse_link: Malformed message received'.
The cause is that bird asynchronously received netlink packet from
wireless driver about some wireless event on its link layer. In that
case bird shouldn't complain.
|
|
Here is a patch fixing a bug that causes breakage of a local routing
table during shutdown of Bird. The problem was caused by shutdown
of 'device' protocol before shutdown of 'kernel' protocol. When
'device' protocol went down, the route (with local network prefix)
From different protocol (BGP or OSPF) became preferred and installed
to the kernel routing table. Such routes were broken (like
192.168.1.0/24 via 192.168.1.2). I think it is also the cause
of problem reported by Martin Kraus.
The patch disables updating of kernel routing table during shutdown of
Bird. I am not sure whether this is the best way to fix it, I would
prefer to forbid 'kernel' protocol to overwrite routes with
'proto kernel'.
The patch also fixes a problem that during shutdown sometimes routes
created by Bird remained in the kernel routing table.
|