neocturne/JRummikub
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Added variant buttons to option panel

Browse source 
git-svn-id: svn://sunsvr01.isp.uni-luebeck.de/swproj13/trunk@416 72836036-5685-4462-b002-a69064685172
This commit is contained in:
Matthias Schiffer 2011-06-11 04:45:28 +02:00
parent 4fbbcb5e06
commit 6ac71b62e3
5 changed files with 175 additions and 95 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
mock/jrummikub/view/MockSettingsPanel.java
View file

@ -41,6 +41,10 @@ public class MockSettingsPanel implements ISettingsPanel {
/** */ /** */
public boolean removePlayerButtonsEnabled = false; public boolean removePlayerButtonsEnabled = false;
/** */
public MockEvent setVariantDefaultEvent = new MockEvent();
/** */
public MockEvent setVariantChildrenEvent = new MockEvent();
/** */ /** */
public MockEvent1<Integer> changeInitialMeldThresholdEvent = new MockEvent1<Integer>(); public MockEvent1<Integer> changeInitialMeldThresholdEvent = new MockEvent1<Integer>();
/** */ /** */
@ -173,4 +177,14 @@ public class MockSettingsPanel implements ISettingsPanel {
public IEvent1<Boolean> getChangeNoLimitsEvent() { public IEvent1<Boolean> getChangeNoLimitsEvent() {
return changeNoLimitsEvent; return changeNoLimitsEvent;
} }
@Override
public IEvent getSetVariantDefaultEvent() {
return setVariantDefaultEvent;
}
@Override
public IEvent getSetVariantChildrenEvent() {
return setVariantChildrenEvent;
}
} }

50
src/jrummikub/control/SettingsControl.java
View file

@ -34,9 +34,9 @@ public class SettingsControl {
* Create a new settings control * Create a new settings control
* *
* @param view * @param view
* the view to use * the view to use
* @param settings * @param settings
* initial game settings * initial game settings
*/ */
public SettingsControl(IView view, GameSettings settings) { public SettingsControl(IView view, GameSettings settings) {
this.view = view; this.view = view;
@ -44,8 +44,8 @@ public class SettingsControl {
} }
/** /**
* the start game event is emitted when the user wants to start a game and * the start game event is emitted when the user wants to start a game and the
* the settings made are valid * settings made are valid
* *
* @return the event * @return the event
*/ */
@ -78,8 +78,7 @@ public class SettingsControl {
private void addOptionListeners1() { private void addOptionListeners1() {
connections.add(view.getSettingsPanel() connections.add(view.getSettingsPanel()
.getChangeInitialMeldThresholdEvent() .getChangeInitialMeldThresholdEvent().add(new IListener1<Integer>() {
.add(new IListener1<Integer>() {
@Override @Override
public void handle(Integer value) { public void handle(Integer value) {
settings.setInitialMeldThreshold(value); settings.setInitialMeldThreshold(value);
@ -104,8 +103,7 @@ public class SettingsControl {
update(); update();
} }
})); }));
connections.add(view.getSettingsPanel() connections.add(view.getSettingsPanel().getChangeNumberOfStonesDealtEvent()
.getChangeNumberOfStonesDealtEvent()
.add(new IListener1<Integer>() { .add(new IListener1<Integer>() {
@Override @Override
public void handle(Integer value) { public void handle(Integer value) {
@ -149,6 +147,26 @@ public class SettingsControl {
update(); update();
} }
})); }));
connections.add(view.getSettingsPanel().getSetVariantDefaultEvent()
.add(new IListener() {
@Override
public void handle() {
settings.reset();
update();
}
}));
connections.add(view.getSettingsPanel().getSetVariantChildrenEvent()
.add(new IListener() {
@Override
public void handle() {
settings.reset();
settings.setHighestValue(10);
settings.setJokerNumber(6);
settings.setTime(120);
settings.setInitialMeldThreshold(20);
update();
}
}));
} }
private void addPlayerSettingsListeners() { private void addPlayerSettingsListeners() {
@ -221,8 +239,7 @@ public class SettingsControl {
break; break;
} }
settings.getPlayerList().add( settings.getPlayerList().add(new PlayerSettings("Spieler " + num, color));
new PlayerSettings("Spieler " + num, color));
update(); update();
} }
@ -263,9 +280,8 @@ public class SettingsControl {
protected void update() { protected void update() {
view.getSettingsPanel().enableRemovePlayerButtons( view.getSettingsPanel().enableRemovePlayerButtons(
settings.getPlayerList().size() > 2); settings.getPlayerList().size() > 2);
view.getSettingsPanel() view.getSettingsPanel().enableAddPlayerButton(
.enableAddPlayerButton( settings.getPlayerList().size() < ISettingsPanel.PLAYER_COLORS.length);
settings.getPlayerList().size() < ISettingsPanel.PLAYER_COLORS.length);
checkSettings(); checkSettings();
@ -286,9 +302,8 @@ public class SettingsControl {
for (int j = i + 1; j < settings.getPlayerList().size(); ++j) { for (int j = i + 1; j < settings.getPlayerList().size(); ++j) {
if (settings.getPlayerList().get(j).getName().equals(name)) { if (settings.getPlayerList().get(j).getName().equals(name)) {
view.getSettingsPanel() view.getSettingsPanel().setError(
.setError( ISettingsPanel.SettingsError.DUPLICATE_PLAYER_NAME_ERROR);
ISettingsPanel.SettingsError.DUPLICATE_PLAYER_NAME_ERROR);
view.getSettingsPanel().enableStartGameButton(false); view.getSettingsPanel().enableStartGameButton(false);
return false; return false;
} }
@ -297,8 +312,7 @@ public class SettingsControl {
int totalStonesDealt = settings.getNumberOfStonesDealt() int totalStonesDealt = settings.getNumberOfStonesDealt()
* settings.getPlayerList().size(); * settings.getPlayerList().size();
int totalStones = settings.getHighestValue() int totalStones = settings.getHighestValue() * settings.getStoneSetNumber()
* settings.getStoneSetNumber()
* settings.getStoneColors().size() + settings.getJokerNumber(); * settings.getStoneColors().size() + settings.getJokerNumber();
if (totalStones <= totalStonesDealt) { if (totalStones <= totalStonesDealt) {

4
src/jrummikub/model/GameSettings.java
View file

@ -31,6 +31,10 @@ public class GameSettings implements Serializable {
* Creates new GameSettings with default values * Creates new GameSettings with default values
*/ */
public GameSettings() { public GameSettings() {
reset();
}
public void reset() {
initialMeldThreshold = 30; initialMeldThreshold = 30;
jokerPoints = 50; jokerPoints = 50;
jokerNumber = 2; jokerNumber = 2;

6
src/jrummikub/view/ISettingsPanel.java
View file

@ -6,7 +6,6 @@ import java.util.Set;
import jrummikub.control.turn.TurnControlFactory; import jrummikub.control.turn.TurnControlFactory;
import jrummikub.model.GameSettings; import jrummikub.model.GameSettings;
import jrummikub.model.StoneColor; import jrummikub.model.StoneColor;
import jrummikub.util.Event1;
import jrummikub.util.IEvent; import jrummikub.util.IEvent;
import jrummikub.util.IEvent1; import jrummikub.util.IEvent1;
import jrummikub.util.IEvent2; import jrummikub.util.IEvent2;
@ -175,6 +174,10 @@ public interface ISettingsPanel {
public IEvent1<Boolean> getChangeNoLimitsEvent(); public IEvent1<Boolean> getChangeNoLimitsEvent();
public IEvent getSetVariantDefaultEvent();
public IEvent getSetVariantChildrenEvent();
/** /**
* Specifies the different kinds of settings errors that can be displayed * Specifies the different kinds of settings errors that can be displayed
*/ */
@ -196,5 +199,4 @@ public interface ISettingsPanel {
/** Only computer players added */ /** Only computer players added */
COMPUTER_PLAYERS_ONLY_WARNING COMPUTER_PLAYERS_ONLY_WARNING
} }
} }

196
src/jrummikub/view/impl/SettingsPanel.java
View file

@ -10,6 +10,7 @@ import java.awt.GridBagConstraints;
import java.awt.GridBagLayout; import java.awt.GridBagLayout;
import java.awt.GridLayout; import java.awt.GridLayout;
import java.awt.Insets; import java.awt.Insets;
import java.awt.LayoutManager;
import java.awt.event.ActionEvent; import java.awt.event.ActionEvent;
import java.awt.event.ActionListener; import java.awt.event.ActionListener;
import java.awt.event.MouseAdapter; import java.awt.event.MouseAdapter;
@ -68,17 +69,19 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
private JButton addPlayerButton; private JButton addPlayerButton;
private JLabel errorMessageLabel; private JLabel errorMessageLabel;
private JButton startButton; private JButton startButton;
private JCheckBox noLimitsBox;
private boolean removeButtonsEnabled = true; private boolean removeButtonsEnabled = true;
private List<PlayerSettingsPanel> playerSettingsPanels = new ArrayList<PlayerSettingsPanel>(); private List<PlayerSettingsPanel> playerSettingsPanels = new ArrayList<PlayerSettingsPanel>();
private JButton setVariantDefaultButton;
private JButton setVariantChildrenButton;
private JSpinner initialMeldThresholdSpinner; private JSpinner initialMeldThresholdSpinner;
private JSpinner stoneSetNumberSpinner; private JSpinner stoneSetNumberSpinner;
private JSpinner highestValueSpinner; private JSpinner highestValueSpinner;
private JSpinner numberOfStonesDealtSpinner; private JSpinner numberOfStonesDealtSpinner;
private JSpinner jokerNumberSpinner; private JSpinner jokerNumberSpinner;
private JSpinner timeSpinner; private JSpinner timeSpinner;
private JCheckBox noLimitsBox;
private JPanel colorSelectionPanel; private JPanel colorSelectionPanel;
private Map<StoneColor, JToggleButton> colorButtons = new HashMap<StoneColor, JToggleButton>(); private Map<StoneColor, JToggleButton> colorButtons = new HashMap<StoneColor, JToggleButton>();
@ -99,6 +102,8 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
private Event1<Set<StoneColor>> changeStoneColorsEvent = new Event1<Set<StoneColor>>(); private Event1<Set<StoneColor>> changeStoneColorsEvent = new Event1<Set<StoneColor>>();
private Event1<Integer> changeTimeEvent = new Event1<Integer>(); private Event1<Integer> changeTimeEvent = new Event1<Integer>();
private Event1<Boolean> changeNoLimitsEvent = new Event1<Boolean>(); private Event1<Boolean> changeNoLimitsEvent = new Event1<Boolean>();
private Event setVariantDefaultEvent = new Event();
private Event setVariantChildrenEvent = new Event();
@Override @Override
public IEvent getStartGameEvent() { public IEvent getStartGameEvent() {
@ -178,40 +183,50 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
return changeStoneColorsEvent; return changeStoneColorsEvent;
} }
@Override
public IEvent getSetVariantDefaultEvent() {
return setVariantDefaultEvent;
}
@Override
public IEvent getSetVariantChildrenEvent() {
return setVariantChildrenEvent;
}
@Override @Override
public void setError(SettingsError error) { public void setError(SettingsError error) {
switch (error) { switch (error) {
case NO_ERROR: case NO_ERROR:
errorMessageLabel.setText(" "); errorMessageLabel.setText(" ");
break; break;
case DUPLICATE_PLAYER_NAME_ERROR: case DUPLICATE_PLAYER_NAME_ERROR:
errorMessageLabel errorMessageLabel
.setText("Jeder Spielername darf nur einmal verwendet werden."); .setText("Jeder Spielername darf nur einmal verwendet werden.");
errorMessageLabel.setForeground(Color.RED); errorMessageLabel.setForeground(Color.RED);
break; break;
case NO_PLAYER_NAME_ERROR: case NO_PLAYER_NAME_ERROR:
errorMessageLabel.setText("Jeder Spieler muss einen Namen haben."); errorMessageLabel.setText("Jeder Spieler muss einen Namen haben.");
errorMessageLabel.setForeground(Color.RED); errorMessageLabel.setForeground(Color.RED);
break; break;
case NOT_ENOUGH_STONES_ERROR: case NOT_ENOUGH_STONES_ERROR:
errorMessageLabel errorMessageLabel
.setText("Es gibt nicht genug Steine f\u00fcr die gew\u00e4hlte Spieleranzahl."); .setText("Es gibt nicht genug Steine f\u00fcr die gew\u00e4hlte Spieleranzahl.");
errorMessageLabel.setForeground(Color.RED); errorMessageLabel.setForeground(Color.RED);
break; break;
case NOT_ENOUGH_COLORS_ERROR: case NOT_ENOUGH_COLORS_ERROR:
errorMessageLabel errorMessageLabel
.setText("Es m\u00fcssen mindestens drei Farben ausgew\u00e4hlt werden."); .setText("Es m\u00fcssen mindestens drei Farben ausgew\u00e4hlt werden.");
errorMessageLabel.setForeground(Color.RED); errorMessageLabel.setForeground(Color.RED);
break; break;
case COMPUTER_PLAYERS_ONLY_WARNING: case COMPUTER_PLAYERS_ONLY_WARNING:
errorMessageLabel.setText("Es gibt keinen menschlichen Spieler."); errorMessageLabel.setText("Es gibt keinen menschlichen Spieler.");
errorMessageLabel.setForeground(Color.ORANGE.darker()); errorMessageLabel.setForeground(Color.ORANGE.darker());
break; break;
case TOO_HIGH_THRESHOLD_WARNING: case TOO_HIGH_THRESHOLD_WARNING:
errorMessageLabel errorMessageLabel
.setText("Die gew\u00e4hlte Schranke ist m\u00f6glicherweise zu hoch"); .setText("Die gew\u00e4hlte Schranke ist m\u00f6glicherweise zu hoch");
errorMessageLabel.setForeground(Color.ORANGE.darker()); errorMessageLabel.setForeground(Color.ORANGE.darker());
break; break;
} }
} }
@ -236,8 +251,7 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
@Override @Override
public void setGameSettings(GameSettings gameSettings) { public void setGameSettings(GameSettings gameSettings) {
while (playerSettingsPanels.size() > gameSettings.getPlayerList() while (playerSettingsPanels.size() > gameSettings.getPlayerList().size()) {
.size()) {
removePlayerSettingsPanel(); removePlayerSettingsPanel();
} }
@ -245,12 +259,11 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
updatePlayerSettingsPanel(i, gameSettings.getPlayerList().get(i)); updatePlayerSettingsPanel(i, gameSettings.getPlayerList().get(i));
} }
initialMeldThresholdSpinner.setValue(gameSettings initialMeldThresholdSpinner
.getInitialMeldThreshold()); .setValue(gameSettings.getInitialMeldThreshold());
stoneSetNumberSpinner.setValue(gameSettings.getStoneSetNumber()); stoneSetNumberSpinner.setValue(gameSettings.getStoneSetNumber());
highestValueSpinner.setValue(gameSettings.getHighestValue()); highestValueSpinner.setValue(gameSettings.getHighestValue());
numberOfStonesDealtSpinner.setValue(gameSettings numberOfStonesDealtSpinner.setValue(gameSettings.getNumberOfStonesDealt());
.getNumberOfStonesDealt());
jokerNumberSpinner.setValue(gameSettings.getJokerNumber()); jokerNumberSpinner.setValue(gameSettings.getJokerNumber());
timeSpinner.setValue(gameSettings.getTime()); timeSpinner.setValue(gameSettings.getTime());
noLimitsBox.setSelected(gameSettings.isNoLimits()); noLimitsBox.setSelected(gameSettings.isNoLimits());
@ -279,8 +292,8 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
} }
private void removePlayerSettingsPanel() { private void removePlayerSettingsPanel() {
PlayerSettingsPanel p = playerSettingsPanels PlayerSettingsPanel p = playerSettingsPanels.remove(playerSettingsPanels
.remove(playerSettingsPanels.size() - 1); .size() - 1);
playerSettingsViewport.remove(p); playerSettingsViewport.remove(p);
} }
@ -302,8 +315,7 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
playerSettingsViewport.add(addPlayerPanel); playerSettingsViewport.add(addPlayerPanel);
addPlayerButton = new JButton("+"); addPlayerButton = new JButton("+");
addPlayerButton addPlayerButton.setFont(addPlayerButton.getFont().deriveFont(Font.BOLD));
.setFont(addPlayerButton.getFont().deriveFont(Font.BOLD));
addPlayerButton.addActionListener(new ActionListener() { addPlayerButton.addActionListener(new ActionListener() {
@Override @Override
public void actionPerformed(ActionEvent e) { public void actionPerformed(ActionEvent e) {
@ -323,38 +335,43 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
GridBagLayout layout = new GridBagLayout(); GridBagLayout layout = new GridBagLayout();
optionsPanel.setLayout(layout); optionsPanel.setLayout(layout);
makeOptionLabel(0, "Auslegeschranke:"); int row = 0;
initialMeldThresholdSpinner = makeOptionSpinner(0, 1, 999, 1,
makeOptionLabel(row, "Variante:");
makeVariantPanel(row++);
makeOptionLabel(row, "Auslegeschranke:");
initialMeldThresholdSpinner = makeOptionSpinner(row++, 1, 999, 1,
changeInitialMeldThresholdEvent); changeInitialMeldThresholdEvent);
makeOptionLabel(1, "Anzahl Steins\u00e4tze:"); makeOptionLabel(row, "Anzahl Steins\u00e4tze:");
stoneSetNumberSpinner = makeOptionSpinner(1, 1, 999, 1, stoneSetNumberSpinner = makeOptionSpinner(row++, 1, 999, 1,
changeStoneSetNumberEvent); changeStoneSetNumberEvent);
makeOptionLabel(2, "H\u00f6chster Steinwert:"); makeOptionLabel(row, "H\u00f6chster Steinwert:");
highestValueSpinner = makeOptionSpinner(2, 3, 99, 1, highestValueSpinner = makeOptionSpinner(row++, 3, 99, 1,
changeHighestValueEvent); changeHighestValueEvent);
makeOptionLabel(3, "Anzahl Startsteine:"); makeOptionLabel(row, "Anzahl Startsteine:");
numberOfStonesDealtSpinner = makeOptionSpinner(3, 1, 999, 1, numberOfStonesDealtSpinner = makeOptionSpinner(row++, 1, 999, 1,
changeNumberOfStonesDealtEvent); changeNumberOfStonesDealtEvent);
makeOptionLabel(4, "Jokeranzahl:"); makeOptionLabel(row, "Jokeranzahl:");
jokerNumberSpinner = makeOptionSpinner(4, 1, 999, 1, jokerNumberSpinner = makeOptionSpinner(row++, 1, 999, 1,
changeJokerNumberEvent); changeJokerNumberEvent);
makeOptionLabel(5, "Zeit für Spielzug:"); makeOptionLabel(row, "Zeit für Spielzug:");
timeSpinner = makeOptionSpinner(5, 1, 999, 1, changeTimeEvent); timeSpinner = makeOptionSpinner(row++, 1, 999, 1, changeTimeEvent);
makeOptionLabel(6, "No Limits:"); makeOptionLabel(row, "No Limits:");
noLimitsBox = makeOptionCheckbox(6, changeNoLimitsEvent); noLimitsBox = makeOptionCheckbox(row++, changeNoLimitsEvent);
makeOptionLabel(7, "Steinfarben:"); makeOptionLabel(row, "Steinfarben:");
createColorSelectionPanel(7); createColorSelectionPanel(row++);
GridBagConstraints c = new GridBagConstraints(); GridBagConstraints c = new GridBagConstraints();
c.gridx = 1; c.gridx = 1;
c.gridy = 8; c.gridy = row;
c.fill = GridBagConstraints.BOTH; c.fill = GridBagConstraints.BOTH;
c.weightx = 1; c.weightx = 1;
c.weighty = 1; c.weighty = 1;
@ -404,6 +421,38 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
changeStoneColorsEvent.emit(colors); changeStoneColorsEvent.emit(colors);
} }
private void makeVariantPanel(int row) {
JPanel panel = makeOptionSubpanel(row, new GridLayout(1, 2, 5, 0));
setVariantDefaultButton = new JButton("Standard");
panel.add(setVariantDefaultButton);
setVariantDefaultButton.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent e) {
setVariantDefaultEvent.emit();
}
});
setVariantChildrenButton = new JButton("Kinder");
panel.add(setVariantChildrenButton);
setVariantChildrenButton.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent e) {
setVariantChildrenEvent.emit();
}
});
}
private JPanel makeOptionSubpanel(int row, LayoutManager layout) {
GridBagConstraints c = new GridBagConstraints();
c.anchor = GridBagConstraints.WEST;
c.gridx = 1;
c.gridy = row;
c.insets = new Insets(2, 2, 2, 2);
JPanel panel = new JPanel(layout);
optionsPanel.add(panel, c);
return panel;
}
private JCheckBox makeOptionCheckbox(int row, private JCheckBox makeOptionCheckbox(int row,
final Event1<Boolean> targetEvent) { final Event1<Boolean> targetEvent) {
GridBagConstraints c = new GridBagConstraints(); GridBagConstraints c = new GridBagConstraints();
@ -431,8 +480,8 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
c.insets = new Insets(2, 2, 2, 2); c.insets = new Insets(2, 2, 2, 2);
final JSpinner spinner = new JSpinner(); final JSpinner spinner = new JSpinner();
spinner.setModel(new SpinnerNumberModel(min, min, max, step)); spinner.setModel(new SpinnerNumberModel(min, min, max, step));
spinner.setPreferredSize(new Dimension(60, spinner
spinner.getMinimumSize().height)); .setPreferredSize(new Dimension(60, spinner.getMinimumSize().height));
spinner.addChangeListener(new ChangeListener() { spinner.addChangeListener(new ChangeListener() {
@Override @Override
public void stateChanged(ChangeEvent e) { public void stateChanged(ChangeEvent e) {
@ -495,8 +544,8 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
c.gridwidth = GridBagConstraints.REMAINDER; c.gridwidth = GridBagConstraints.REMAINDER;
addButton("Netzwerkspiel...", networkGameEvent, c); addButton("Netzwerkspiel...", networkGameEvent, c);
setBorder(new CompoundBorder(new LineBorder(Color.BLACK), setBorder(new CompoundBorder(new LineBorder(Color.BLACK), new EmptyBorder(
new EmptyBorder(10, 10, 10, 10))); 10, 10, 10, 10)));
} }
void resetTabbedPane() { void resetTabbedPane() {
@ -533,8 +582,8 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
if (index != playerType.getSelectedIndex()) { if (index != playerType.getSelectedIndex()) {
playerType.setSelectedIndex(index); playerType.setSelectedIndex(index);
} }
colorButton.setIcon(ImageUtil.createColorIcon(settings.getColor(), colorButton
16, 2)); .setIcon(ImageUtil.createColorIcon(settings.getColor(), 16, 2));
} }
public void enableRemoveButton(boolean enable) { public void enableRemoveButton(boolean enable) {
@ -582,8 +631,7 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
c.gridy = 0; c.gridy = 0;
add(colorButton, c); add(colorButton, c);
nameField.getDocument().addDocumentListener( nameField.getDocument().addDocumentListener(new NameChangeListener());
new NameChangeListener());
c2.gridy = 0; c2.gridy = 0;
c2.weightx = 1; c2.weightx = 1;
c2.fill = GridBagConstraints.HORIZONTAL; c2.fill = GridBagConstraints.HORIZONTAL;
@ -616,9 +664,8 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
public Dimension getPreferredSize() { public Dimension getPreferredSize() {
Dimension preferredSize = super.getPreferredSize(); Dimension preferredSize = super.getPreferredSize();
for (Component component : this.getComponents()) { for (Component component : this.getComponents()) {
preferredSize.setSize( preferredSize
preferredSize.width, .setSize(preferredSize.width, Math.max(preferredSize.height,
Math.max(preferredSize.height,
component.getPreferredSize().height)); component.getPreferredSize().height));
} }
return preferredSize; return preferredSize;
@ -628,9 +675,8 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
public Dimension getMaximumSize() { public Dimension getMaximumSize() {
Dimension preferredSize = super.getPreferredSize(); Dimension preferredSize = super.getPreferredSize();
for (Component component : this.getComponents()) { for (Component component : this.getComponents()) {
preferredSize.setSize( preferredSize
Integer.MAX_VALUE, .setSize(Integer.MAX_VALUE, Math.max(preferredSize.height,
Math.max(preferredSize.height,
component.getPreferredSize().height)); component.getPreferredSize().height));
} }
return preferredSize; return preferredSize;
@ -645,8 +691,8 @@ class SettingsPanel extends JPanel implements ISettingsPanel {
} }
private void changeType() { private void changeType() {
changePlayerTypeEvent.emit(playerNumber, TurnControlFactory.Type changePlayerTypeEvent.emit(playerNumber,
.values()[playerType.getSelectedIndex()]); TurnControlFactory.Type.values()[playerType.getSelectedIndex()]);
} }
private void remove() { private void remove() {