diff options
author | Matthias Schiffer <matthias@gamezock.de> | 2008-09-16 01:20:43 +0200 |
---|---|---|
committer | Matthias Schiffer <matthias@gamezock.de> | 2008-09-16 01:20:43 +0200 |
commit | cc35771abf4fc7e0dd472bd818ff2b4962c7e204 (patch) | |
tree | 682bc38ffbf5954a93b1967a700f40bd78038ee4 /src/Core/RequestHandlers/DaemonListRequestHandler.cpp | |
parent | 2226256eedb2849f387ff566893a91bf5da3cdc9 (diff) | |
download | mad-cc35771abf4fc7e0dd472bd818ff2b4962c7e204.tar mad-cc35771abf4fc7e0dd472bd818ff2b4962c7e204.zip |
Bessere Fehlerbehandlung
Diffstat (limited to 'src/Core/RequestHandlers/DaemonListRequestHandler.cpp')
-rw-r--r-- | src/Core/RequestHandlers/DaemonListRequestHandler.cpp | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/src/Core/RequestHandlers/DaemonListRequestHandler.cpp b/src/Core/RequestHandlers/DaemonListRequestHandler.cpp index 1f137ad..2bee423 100644 --- a/src/Core/RequestHandlers/DaemonListRequestHandler.cpp +++ b/src/Core/RequestHandlers/DaemonListRequestHandler.cpp @@ -20,15 +20,23 @@ #include "DaemonListRequestHandler.h" #include "../ConnectionManager.h" #include <Net/Connection.h> +#include <Net/Packets/ErrorPacket.h> #include <Net/Packets/NameListPacket.h> +#include <iostream> + namespace Mad { namespace Core { namespace RequestHandlers { -bool DaemonListRequestHandler::handlePacket(Net::Connection *connection, const Net::Packet &packet) { - if(packet.getType() != Net::Packet::LIST_DAEMONS) - return false; // TODO Logging +void DaemonListRequestHandler::handlePacket(Net::Connection *connection, const Net::Packet &packet) { + if(packet.getType() != Net::Packet::LIST_DAEMONS) { + std::cerr << "Received an unexpected packet." << std::endl; + connection->send(Net::Packets::ErrorPacket(Net::Packet::ERROR, packet.getRequestId(), Common::Exception(Common::Exception::UNEXPECTED_PACKET))); + + signalFinished().emit(); + return; + } // TODO Require authentication @@ -38,12 +46,9 @@ bool DaemonListRequestHandler::handlePacket(Net::Connection *connection, const N for(std::map<std::string,DaemonInfo>::iterator daemon = daemons.begin(); daemon != daemons.end(); ++daemon) names.push_back(daemon->first); - if(!connection->send(Net::Packets::NameListPacket(Net::Packet::OK, packet.getRequestId(), names))) - return false; + connection->send(Net::Packets::NameListPacket(Net::Packet::OK, packet.getRequestId(), names)); signalFinished().emit(); - - return true; } } |